Base Cordova build off of upstream web build #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (651 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/de/
Currently translated at 99.5% (648 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fi/
Currently translated at 100.0% (651 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fr/
Currently translated at 100.0% (651 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/
Currently translated at 100.0% (651 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/en_GB/
Currently translated at 100.0% (651 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/
Currently translated at 23.3% (152 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hi/
Currently translated at 100.0% (651 of 651 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hr/
Added overflow-wrap break word so that more of the clipped title is displayed. Co-authored-by: Simon Epstein <[email protected]>
* Fix strange embed playlist links missing / * support embed/videoseries links * remove duplicated replace line Co-authored-by: petaded <[email protected]>
* initial commit * remove extra play button toggle * add missing comment Co-authored-by: Alin <[email protected]> Co-authored-by: ChunkyPtogrammer <[email protected]>
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/tr/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/uk/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hant/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/
* Improve Watch page accessibility Co-Authored-By: Jason <[email protected]> * fix title issue, remove unused gotochannel function Co-authored-by: Jason <[email protected]>
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_PT/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ja/
Currently translated at 100.0% (653 of 653 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/
Currently translated at 100.0% (657 of 657 strings) Translation: FreeTube/Translations Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/
; I am having trouble with getting a release build signed.
`development` is now `nightly` and what was `nightly` is now `release`.
MarmadileManteater
added a commit
that referenced
this pull request
Jan 22, 2023
commit bed2485 Merge: c7e7e7e 7ccb5dd Author: Emma <[email protected]> Merge remote-tracking branch 'upstream/development' into development commit c7e7e7e Author: Emma <[email protected]> Base Cordova build off of upstream web build (#84) commit 7ccb5dd Author: Emma <[email protected]> Adjust `side-nav-more-options` to account for anchor style (FreeTubeApp#3097) ... **Full Changelog**: 0.18.0-nightly-80...0.18.0-nightly-81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base Cordova build off of upstream web build
Related Issues
#10
Description
Up until this point, the Cordova build process has involved taking the webpack output of a modified version of the
webpack.renderer.config.jsand forcing it through browserify. However, there is now a working web build upstream, so I felt like it would make more sense to base the Cordova build off of the upstream web build. Additionally, the original build process is difficult to maintain; it 😖breaks frequently, and since the move to YouTube.js for Local API upstream, I have not been able to pull in any upstream changes to the current development branch because browserify does not like something about how YouTube.js is included. The 🚚move to YouTube.js is ultimately a very positive change, but it was the straw that broke the 🐪back of the originalcordova-build.js.This PR is a complete refactor of the entire build process which removes many unnecessary steps and speeds up the entire process. It changes all of the
package.jsonscripts related to Cordova:yarn pack:browseris now ->yarn pack:cordova(for Android builds) &yarn pack:web(for web builds)yarn build:cordovais still the same command, but you no longer need to run it before running:yarn run:cordovabrowserorcordovaas the first argument. That argument is just skipped now. It isn't necessary anymore.yarn run:cordovabuilds the app and launches it on a connected Android device. If you want to debug the web app in a browser, you can now useyarn dev:web.This PR also includes a few changes which I never got around to implementing in the old build process before I stopped being able to update it. Such as:
This PR also aims to clean-up the environments to make them more inline with upstream. Development is now where nightly builds live. Nightly builds can be found under GH actions just like it says in the
README. Release is where releases live. Ideally, I will refrain from pushing releases to release as often as I have been with nightly, and this should reduce the amount of app updates pushed to users of the app who downloaded from IzzyOnDroid.Screenshots